Code usability improvement #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
how to use library code has been added in your code
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
text reordered
|
Signed.
…On Wed, 12 Jun, 2024, 4:01 pm github-actions[bot], ***@***.***> wrote:
*CLA Assistant Lite bot:*
Thank you for your submission, we really appreciate it. Like many
open-source projects, we ask that you sign our Contributor License
Agreement <https://github.com/VikParuchuri/marker/blob/master/CLA.md>
before we can accept your contribution. You can sign the CLA by just
posting a Pull Request Comment same as the below format.
------------------------------
I have read the CLA Document and I hereby sign the CLA
------------------------------
You can retrigger this bot by commenting *recheck* in this Pull Request
—
Reply to this email directly, view it on GitHub
<#190 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARVRYJA4OGMSH5Q6QDU2O5DZHAPO7AVCNFSM6AAAAABJGCDVY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSGY3DKNRYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| output_dir (str): Directory to save the converted Markdown file. | ||
| max_pages (int, optional): Maximum number of pages to convert. Defaults to 10. | ||
| start_page (int, optional): Page number to start conversion from. Defaults to 1. |
There was a problem hiding this comment.
Should the start page not default to 0?
I had an error when trying this with a single page pdf until I changed start_page from 1 to 0
frankbaele
reviewed
Aug 27, 2024
There was a problem hiding this comment.
The project already contains a poetry lock file, so no need for requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will make the code easier for the programmer to use.