Update Voting.sol: Enhanced 'Slots' usage #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our team will soon review your PR. Thanks @Aryan9592 :) |
|
Closing due to inactivity! |
|
Thank you @0xScratch for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
The contract is using more
slotsthan necessary. Actually, EVM provided every smart contract some slots for storage. The more you use them, the more the gas costs. Thus, finding a way to reduce them is a great way to have some gas optimizations👨💻 Changes proposed
Just changed the order of state variables. For a better explanation, refer this PR -> allo-protocol/allo-v2#237
✔️ Check List (Check all the applicable boxes)