[pull] master from pitchmuc:master #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
sorry for the previous void PRs.
Add getAlerts method (now also with `definition` parameter)
|
|
getAlert - gets individual Alert updateAlert - flexible method to do any kind of Alert updating via parameters disableAlert / enableAlert: disables/enables Alert deleteAlert: deletes Alert renewAlerts: Renews a list of Alerts (the API expects a list of IDs here, that's why it is also the only method where we need to pass a list)
Add more Alert methods + reformatting of code.
Right now, the "expansion" parameter for the `getProjects` method is always either the `full` list of `'reportSuiteName,ownerFullName,tags,shares,sharesFullName,modified,favorite,approved,companyTemplate,externalReferences,accessLevel'` or the smaller subset of:
```
params["expansion"] = "ownerFullName,modified"
if includeShared:
params["expansion"] += ',shares,sharesFullName'
if includeTemplate:
params["expansion"] += ',companyTemplate'
```
In some cases where clients have 10s of thousands of projects, you can speed up the query by limiting the expansion parameters.
Also, the "externalReferences" expansion parameter causes the getProjects request to fail for a client of mine ("Connection broken"). Since `externalReferences` does not contain anything of value for us, we could live without it, but for that we need a way to query getProjects with a custom expansion parameter list.
This simple change will allow that. So thanks for looking at this, @pitchmuc
If a request fails completely (eg "Connection broken" due to giant segments), the connector.py tries again. However, the second time this happens, there is a conflict between the retry parameter in kwargs and the separate retry parameter which leads to a "keyError: 'retry'" error. This can be avoided via the changes here. I also set time.sleep to the connector.restTime so this is consistent with the rest of the retries.
Avoid keyError: "retry" in case request fails
Allow getProjects with custom expansion parameters (also to avoid issues with externalReferences column)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )