Skip to content

Commit

Permalink
Merge pull request #7 from VilledeMontreal/develop
Browse files Browse the repository at this point in the history
Fix examples by removing scoped dependencies
  • Loading branch information
joscelynjean authored Jun 15, 2020
2 parents e59dcae + 2920771 commit 9922b0c
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 19 deletions.
20 changes: 18 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,20 @@ For examples, check the `examples` folder.
Install the dependency.

```
$ npm install @villedemontreal/idempotency-express
$ npm install express-idempotency
```

Integrate the middleware in your Express initialization.

```javascript
// Javascript
const idempotency = require('express-idempotency');
// ...express initialization
app.post('*', idempotency.idempotency());

// Typescript
import { idempotency } from 'express-idempotency';
// ...express initialization
app.post('*', idempotency());
```

Expand Down Expand Up @@ -180,12 +188,20 @@ Pour des exemples, voir le répertoire `examples`.
Installation de la dépendance.
```
$ npm install @villedemontreal/idempotency-express
$ npm install express-idempotency
```
Intégrer le middleware dans l'initialisation de votre application Express.
```javascript
// Javascript
const idempotency = require('express-idempotency');
// ...initialisation de Express
app.post('*', idempotency.idempotency());

// Typescript
import { idempotency } from 'express-idempotency';
// ...initialisation de Express
app.post('*', idempotency());
```
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-use/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN npm install && npm run compile && npm link

# Installation of package to run the application
WORKDIR /usr/src/app/examples/simple-use
RUN npm link "@villemontreal/express-idempotency" && npm install
RUN npm link "express-idempotency" && npm install

EXPOSE 8080

Expand Down
6 changes: 3 additions & 3 deletions examples/simple-use/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@villemontreal/express-idempotency-example",
"name": "express-idempotency-example",
"version": "1.0.0",
"description": "",
"main": "index.js",
Expand All @@ -9,7 +9,7 @@
"author": "",
"license": "MIT",
"dependencies": {
"@villemontreal/express-idempotency": "1.0.0",
"express-idempotency": "1.0.2",
"express": "^4.17.1"
}
}
}
24 changes: 12 additions & 12 deletions examples/simple-use/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@

const express = require('express');
const app = express();
const idempotency = require('@villemontreal/express-idempotency');
const idempotency = require('express-idempotency');

app.use(idempotency.idempotency());

app.all('/', function (req, res) {
const idempotencyService = idempotency.getSharedIdempotencyService();
if (idempotencyService.isHit(req)) {
console.log('Idempotency middleware did already process the request!');
return;
}
const idempotencyService = idempotency.getSharedIdempotencyService();
if (idempotencyService.isHit(req)) {
console.log('Idempotency middleware did already process the request!');
return;
}

// Return the current date and time
res.send(new Date().toISOString());
// Return the current date and time
res.send(new Date().toISOString());
});

app.listen(8080, function () {
console.log(
'Example app listening on port 8080 with express-idempotency middleware.'
);
});
console.log(
'Example app listening on port 8080 with express-idempotency middleware.'
);
});
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "express-idempotency",
"version": "1.0.1",
"version": "1.0.2",
"description": "",
"main": "dist/index.js",
"typings": "dist/index.d.ts",
Expand Down

0 comments on commit 9922b0c

Please sign in to comment.