Refactor serilog initialization and add module initialization logging #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reveiw task created: https://virtocommerce.atlassian.net/browse/VCST-2477 |
vc-ci
reviewed
Dec 16, 2024
ksavosteev
approved these changes
Dec 17, 2024
vc-ci
reviewed
Dec 18, 2024
vc-ci
reviewed
Dec 19, 2024
…cId` and `UrlFormat` for better guidance on deprecation. Updated logging statements in `ServiceCollectionExtensions.cs` and `Startup.cs` to use `Log.ForContext<Startup>()` for more context-specific logging. Adjusted logging configuration in `appsettings.Development.json` and `appsettings.Production.json` to include settings for `VirtoCommerce.Platform.Web.Startup` and modified logging levels for `VirtoCommerce.Platform.Modules`.
|
vc-ci
reviewed
Dec 19, 2024
vc-ci
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Loggin for Production mode:
Added module initialization and post-initialization logging. Can be enabled by this:
{ "Serilog": { "MinimumLevel": { "Override": { "VirtoCommerce.Platform.Modules": "Debug" } } } }Without setting:
With setting:
https://github.com/serilog/serilog-aspnetcore?tab=readme-ov-file#two-stage-initialization
https://github.com/serilog/serilog-extensions-hosting?tab=readme-ov-file#instructions
Replaced
ConsoleLogwith static Serilog'sLog.LoggerandILoggerinjection support.ILoggerwill not log any messages to Serilog during DI initialization without this changes, because previous implementation registered it at the end of DI registration, after all other services registration.References
QA-test:
Jira-link:
Artifact URL:
Image tag:
ghcr.io/VirtoCommerce/platform:3.874.0-pr-2871-73bd-serilog-and-module-initialization-logging-73bd5596