added handling for default parameters #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
reviewed
Jul 23, 2024
| fail(s"failed with YamlError: $error") | ||
| case Right(foo) => | ||
| assertEquals(foo.a, 1) | ||
| assertEquals(foo.b, "test-3") |
There was a problem hiding this comment.
How about one more case with b specified to assert that the default is not invoked (so times is not incremented) when an argument is given explicitly?
|
|
||
| '{ $namesExpr.zip($identsExpr).toMap } |
There was a problem hiding this comment.
I'm not sure if the order of declarations in body is reliable. Maybe it would be better to use something like sym.companionClass.methodMember("$lessinit$greater$default$" + n.toString).head to get the default value provider method for the n-th field?
prolativ
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had to go from dumb mirrors to a full blown macro for products but hey, mirrors do not expose default params
closes #215