fix: Workaround bug in globwalk. #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As identified in VirusTotal#280 there is a bug in globwalk when using relative paths. Fix it by trying to canonicalize the path, and if that fails falls back to using the relative path. This is fine because the reason canonicalization failed is because the relative path was to a place that doesn't exist, and that does not trigger the bug (it errors out before we get there). We intentionally want this behavior so we get the nicer error reporting with colors. ;) Fixes VirusTotal#280.
|
This change has an undesired side-effect. When you pass a relative path to the scan command (like in |
|
Fixed in bccf19e with a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #280 there is a bug in globwalk when using relative paths. Fix it by trying to canonicalize the path, and if that fails falls back to using the relative path. This is fine because the reason canonicalization failed is because the relative path was to a place that doesn't exist, and that does not trigger the bug (it errors out before we get there). We intentionally want this behavior so we get the nicer error reporting with colors. ;)
Fixes #280.