feat: support polygon crosshair for angleAxis in polar coordinate #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoluoHe
changed the title
xile611
reviewed
Jan 26, 2025
| @@ -16,7 +16,8 @@ Only effective for `type: 'line'`, `width` represents the width of the auxiliary | |||
|
|
|||
| #${prefix} smooth(boolean) | |||
|
|
|||
| Only effective for `type: 'line'`, whether to draw smoothly under the polar coordinate system or not. | |||
| Whether to draw smoothly under the polar coordinate system or not. | |||
| Effective for `type: 'polygon'` since version `1.13.3` | |||
| @@ -32,8 +38,8 @@ export class PolarCrossHair<T extends IPolarCrosshairSpec = IPolarCrosshairSpec> | |||
| private _currValueAngle: AxisCurrentValueMap; | |||
| private _currValueRadius: AxisCurrentValueMap; | |||
|
|
|||
| private _angleHair: IHair | undefined; | |||
| private _radiusHair: IHairRadius | undefined; | |||
| private _angleHair: IPolarHair | undefined; | |||
xiaoluoHe
force-pushed
the
feat/polar-polyon-crosshair
branch
from
59c296a to
f80d29a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough