Merge pull request #1753 from VisActor/fix/text-interpolate

fix: incorrect interpolate for text attribute
VisActor · Feb 24, 2025 · 143ec08 · 143ec08
2 parents fbb36b0 + 13194bf
commit 143ec08
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/common/changes/@visactor/vrender-core/fix-text-interpolate_2025-02-24-06-38.json b/common/changes/@visactor/vrender-core/fix-text-interpolate_2025-02-24-06-38.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vrender-core",
+      "comment": "fix: issue where NAN appears during the text animation process, #1752",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vrender-core"
+}
diff --git a/packages/vrender-core/src/graphic/graphic.ts b/packages/vrender-core/src/graphic/graphic.ts
@@ -1433,7 +1433,7 @@ export abstract class Graphic<T extends Partial<IGraphicAttribute> = Partial<IGr
     nextParsedProps: any,
     ratio: number
   ) {
-    if (Number.isFinite(nextStepVal)) {
+    if (Number.isFinite(nextStepVal) && Number.isFinite(lastStepVal)) {
       nextAttributes[key] = lastStepVal + (nextStepVal - lastStepVal) * ratio;
       return true;
     } else if (key === 'fill') {

diff --git a/packages/vrender-core/src/graphic/text.ts b/packages/vrender-core/src/graphic/text.ts
@@ -657,6 +657,12 @@ export class Text extends Graphic<ITextGraphicAttribute> implements IText {
     return super.needUpdateTag(key, k);
   }
 
+  protected _interpolate(key: string, ratio: number, lastStepVal: any, nextStepVal: any, nextAttributes: any) {
+    if (key === 'text') {
+      nextAttributes.text = nextStepVal;
+    }
+  }
+
   clone(): Text {
     return new Text({ ...this.attribute });
   }