Skip to content

Commit

Permalink
1 Исправления после замечаний КодРевью
Browse files Browse the repository at this point in the history
  • Loading branch information
@VitalyChy
VitalyChy committed Dec 1, 2023
1 parent c9e1ce5 commit 0ba62a8
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 84 deletions.
80 changes: 36 additions & 44 deletions index.html
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<!DOCTYPE html>
<html lang="ru">
<head>
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Оно тебе надо — аукцион вещей, в которые никто не верил</title>
<link rel="stylesheet" href="fonts/fonts.css" />
<link rel="stylesheet" href="styles/global.css" />
<link rel="stylesheet" href="styles/style.css" />
<link rel="stylesheet" href="fonts/fonts.css">
<link rel="stylesheet" href="styles/global.css">
<link rel="stylesheet" href="styles/style.css">
</head>
<body>
<header class="header">
Expand All @@ -29,7 +29,7 @@
class="header__logo-image"
src="./images/logo-black.svg"
alt="Логотип Оно тебе надо"
/>
>
</a>
<address class="header__address address">
<a href="tel:+70000000">+9 999 555 5555</a>
Expand All @@ -41,18 +41,9 @@
<section class="cover">
<div class="overlay"></div>
<h1 class="cover__title">
<span class="aligned-text"
>о<span class="letter-spacing-extended">но</span></span
>
<span class="aligned-text_center"
>те<span class="letter-spacing-extended">бe</span></span
>
<span class="aligned-text_right"
><span class="letter-spacing-extended">н</span>aд<span
class="no-letter-spacing"
>о</span
></span
>
<span class="aligned-text aligned-text_left">о<span class="letter-spacing-extended">но</span></span>
<span class="aligned-text aligned-text_center">те<span class="letter-spacing-extended">бe</span></span>
<span class="aligned-text aligned-text_right"><span class="letter-spacing-extended">н</span>aд<span class="no-letter-spacing">о</span></span>
</h1>
<div class="cover__description">
<p class="cover__description-text">
Expand Down Expand Up @@ -122,20 +113,18 @@ <h3 class="card__title">
class="about__logo-image"
src="./images/logo-white.svg"
alt="Логотип Оно тебе надо"
/>
</div>
<div class="about__column">
<h2 class="about__title">Об аукционе</h2>
>
</div>
<h2 class="about__title">Об аукционе</h2>
<div class="about__text">
<p style="line-height: 23px">
<p>
Здесь вы не встретите очередное пафосное собрание невероятно
дорогого антиквариата. Наши лоты вообще не должны были попасть ни на
один аукцион. Потому что кому нужен дневник девочки-подростка или
картина, которую может нарисовать даже ребёнок? Кому нужны все эти
странные вещи, созданные любителями?
</p>
<p style="line-height: 23px">
<p>
Слишком сложные или, наоборот, слишком простые. Опережающие своё
время. В пух и прах растерзанные критиками. Непринятые и непонятые.
Когда-то они казались просто неудачными. Но, несмотря на критику,
Expand All @@ -147,7 +136,7 @@ <h2 class="about__title">Об аукционе</h2>
</section>
</main>
<footer class="footer">
<address class="footer__address address">
<address class="address">
<a href="tel:+70000000">+9 999 555 5555</a>
<a href="mailto:[email protected]">[email protected]</a>
<p>наб. Принсенграхт 263-265, Амстердам</p>
Expand All @@ -167,28 +156,31 @@ <h2 class="about__title">Об аукционе</h2>
</nav>
<ul class="footer__social-list">
<li class="footer__social-list-item">
<a class="footer__social-link" target="_blank" href="#0"></a>
<img
class="footer__social-icon"
src="./images/yt.svg"
alt="Иконка ссылка на Yootube"
/>
<a class="footer__social-link" target="_blank" href="#0">
<img
class="footer__social-icon"
src="./images/yt.svg"
alt="Иконка ссылка на Yootube"
>
</a>
</li>
<li class="footer__social-list-item">
<a class="footer__social-link" target="_blank" href="#0"></a>
<img
class="footer__social-icon"
src="./images/vk.svg"
alt="Иконка ссылка на ВКонтакте"
/>
<a class="footer__social-link" target="_blank" href="#0">
<img
class="footer__social-icon"
src="./images/vk.svg"
alt="Иконка ссылка на ВКонтакте"
>
</a>
</li>
<li class="footer__social-list-item">
<a class="footer__social-link" target="_blank" href="#0"></a>
<img
class="footer__social-icon"
src="./images/pinterest.svg"
alt="Иконка ссылка на Pinterest"
/>
<a class="footer__social-link" target="_blank" href="#0">
<img
class="footer__social-icon"
src="./images/pinterest.svg"
alt="Иконка ссылка на Pinterest"
>
</a>
</li>
</ul>
</footer>
Expand Down
64 changes: 24 additions & 40 deletions styles/style.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
.cover {
position: relative;
padding: 165px 50px 50px 50px;
background-image: url(/images/cover.jpg);
background-image: url(../images/cover.jpg);
background-repeat: no-repeat;
background-position: center;
background-size: cover;
Expand All @@ -110,24 +110,19 @@
letter-spacing: 30px;
text-transform: uppercase;
}
.aligned-text { /* ОНО */
position: relative;
display: flex;
align-items: center;
align-content: flex-start;
line-height: 115%; /* 115px */

.aligned-text_left { /* ОНО */
line-height: 115%;
}

.aligned-text_center { /* ТЕБЕ */
display: flex;
justify-content: center;
align-items: center;
text-align:center;
}

.aligned-text_right{ /* НАДО */
.aligned-text_right { /* НАДО */
display: flex;
justify-content: flex-end;
align-items: center;
justify-content: end;
align-content: start;
}

.letter-spacing-extended{
Expand Down Expand Up @@ -164,8 +159,8 @@

.bet-button {
flex-shrink: 0;
width: 257px;
height: 52px;
min-width: 257px;
min-height: 52px;
border: 1px solid #FFF;
color: #FFF;
font-family: 'Raleway';
Expand Down Expand Up @@ -205,7 +200,7 @@
flex-direction: column;
justify-content: space-between;
width: 430px;
height: 450px;
min-height: 450px;
padding: 50px 40px;
text-underline-offset: 3.5px;
background-repeat: no-repeat;
Expand All @@ -219,11 +214,12 @@

.lots__card-list {
display: flex;
flex-wrap:wrap;
flex-grow: 1;
justify-content: center;
gap: 25px;
width: 100%;
list-style: none;
list-style: none;
}

.card__title {
Expand All @@ -246,15 +242,15 @@
}

.card_type_film {
background-image: url(/images/card-lot-01.jpg);
background-image: url(../images/card-lot-01.jpg);
}

.card_type_book {
background-image: url(/images/card-lot-02.jpg);
background-image: url(../images/card-lot-02.jpg);
}

.card_type_picture {
background-image: url(/images/card-lot-03.jpg);
background-image: url(../images/card-lot-03.jpg);
}

.card__text {
Expand Down Expand Up @@ -331,13 +327,13 @@
grid-column: 2/4;
grid-row: 2/4;
align-items: flex-start;
gap: 28.5px;
gap: 28.6px;
color: #000;
font-family: 'Raleway';
font-weight: 400;
font-size: 20px;
font-style: normal;
line-height: normal;
line-height: 23.3px;
}

/* 5. Блок Footer */
Expand All @@ -346,19 +342,7 @@
.footer {
display: grid;
grid-template-columns: repeat(3, 1fr);
padding: 83px 50px 90px 50px;
}

.footer__address {
display: flex;
flex-direction: column;
color: #000;
font-family: 'Raleway';
font-weight: 400;
font-size: 18px;
font-style: normal;
line-height: 24.3px; /* 135% */
text-underline-offset: 4.5px;
padding: 85px 50px 90px 50px;
}

.footer__menu {
Expand All @@ -368,12 +352,12 @@
}

.footer__menu-list {
text-align: center;
list-style-type: none;
font-weight: 400;
font-size: 18px;
font-style: normal;
font-weight: 400;
line-height: normal;
text-align: center;
list-style-type: none;
}

.footer__social-list {
Expand All @@ -383,8 +367,8 @@
list-style-type: none; /* Убрал маркер*/
}

.footer__social-icon {
.footer__social-icon {
flex-shrink: 0;
height: 48px;
flex-shrink: 0;
}

0 comments on commit 0ba62a8

Please sign in to comment.