Add integration for Origins mod climbing power

[Techjar]

Unable to test right now as my VR setup is broken, but it does compile at least.

[ma-gician]

Compiled and tested, couldn't climb up the wall with climbing powers still unfortunately. It appears that the modCompileOnly version of Origins is a future version of the mod.

The Origin Mod's version for 1.20.1 is 1.10.0 and Apoli Mod's version is 2.9.0. I changed this and recompiled, but it still did not let me climb up the walls using the Arachnid Origin.
// for origins compat modCompileOnly "maven.modrinth:origins:1.10.0" modCompileOnlyApi "com.github.apace100:apoli:2.9.0"

[fayer3]

that shouldn't matter I'm debugging it atm
the climbing check is wrong, but the power check also doesn't return any powers

[fayer3]

hm maybe it does matter, looks like they had some api changes from 1.20 to 1.20.2 apace100/apoli@e635031

[fayer3]

implements #209

[Techjar]

I fixed the incorrect logic. Not sure about the API stuff.

[Techjar]

Okay, I changed how hasClimbingPower functions, see if the check works now.

[ma-gician]

It works! I compiled the mod, tested with climbing ability, could climb✅, tested without ability, couldn't climb✅. Tried without origins mod installed, couldn't climb ✅. YAY!!!

[Techjar]

Removed the origins mod itself as a compile-time dep since we only actually use classes from apoli.

[ma-gician]

bug(?) i found: when climbing mode hand items are swapped, left hand items in right hand, vice versa.

[Techjar]

I'm not sure I understand what you mean.

[fayer3]

bug(?) i found: when climbing mode hand items are swapped, left hand items in right hand, vice versa.

that must be from a different mod

[Techjar]

Only trouble we have now is that this effectively prevents you from using the other "stick hand in block" contextual interactions system we have, since climbing takes priority over that.

[Techjar]

We now check if the climbing power is toggled on, best we can do to solve that issue. The mod has the toggle bound to G by default.

[ma-gician]

bug(?) i found: when climbing mode hand items are swapped, left hand items in right hand, vice versa.

that must be from a different mod

I'm not sure I understand what you mean.

here's a video showing the glitch with only vivecraft, origins, sodium & others: https://www.youtube.com/watch?v=spmHLP1lFUE
(video recorded before most recent update to it)

[Techjar]

See if that addresses the issue.

[ma-gician]

See if that addresses the issue.

It did. Thank you!

[DarianLStephens]

How goes this?
I was looking at different mods to try in VR, and seeing Origins compatibility got me excited, but there's been no activity here for months.

[ma-gician]

How goes this? I was looking at different mods to try in VR, and seeing Origins compatibility got me excited, but there's been no activity here for months.

if you compile the code it should work! it just hasn't been merged into the main branch yet.

[fayer3]

hm @Techjar could you resolve the confict please? I'm not 100% sure what goes where

[Techjar]

Converting this to a draft as it needs some reworking to function correctly with changes on the master branch.

[Techjar]

I think that's sufficient to make it compatible with the new model replacement logic. Please verify and I'll mark it ready again. Specifically, your main hand item renderers shouldn't be swapped or replaced in either first or third person when you have the climbing power without the claws.

[fayer3]

seems to work fine with origins on fabric, didn't notice any item swapping.
taht the climbing is always on is inteded right? just checking.
also it doesn't work with the origins forge port, because they seem to not have ported the power holder for some reason https://github.com/EdwinMindcraft/apoli/blob/1.20.x/forge/src/main/java/io/github/apace100/apoli/component/PowerHolderComponent.java
so need to exclude that somehow, or fix it with that, because right now it crashes on on world load.
adding a class and field check might be safe to do, for just excluding.

[ma-gician]

seems to work fine with origins on fabric, didn't notice any item swapping. taht the climbing is always on is inteded right? just checking. also it doesn't work with the origins forge port, because they seem to not have ported the power holder for some reason https://github.com/EdwinMindcraft/apoli/blob/1.20.x/forge/src/main/java/io/github/apace100/apoli/component/PowerHolderComponent.java so need to exclude that somehow, or fix it with that, because right now it crashes on on world load. adding a class and field check might be safe to do, for just excluding.

So, I added a check to see if the player is using fabric.

VivecraftMod-origins-integration\common\src\main\java\org\vivecraft\mod_compat_vr\origins\OriginsHelper.java
Line 11
return Xplat.isModLoaded("origins") && Xplat.isModLoaded("fabric-api");

It disables the extra functionality for Forge. This also stops the game from crashing due to the power holder not being ported when joining a world.

Fabric still functions as expected.

[fayer3]

we have an Xplat call to check the modloader, and there are forge ports of the fabric api
using reflection to check for the existence is a better way imo, and will make it work automatically when they finally port that to forge

[ma-gician]

Oh, thanks for the information! I'm inexperienced with minecraft modding & java.

Unfortunately, I don't think they're going to port it.
EdwinMindcraft/origins-architectury#483
It seems to be discontinued

[ma-gician]

we have an Xplat call to check the modloader, and there are forge ports of the fabric api using reflection to check for the existence is a better way imo, and will make it work automatically when they finally port that to forge

return Xplat.isModLoaded("origins") && Xplat.getModloader() == "fabric";
?

I think that's sufficient to make it compatible with the new model replacement logic. Please verify and I'll mark it ready again. Specifically, your main hand item renderers shouldn't be swapped or replaced in either first or third person when you have the climbing power without the claws.

Verified
@Techjar