Sector/more fixes 2 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for the contains() and remove() methods of PojoEntityPool.
Update the tests for BaseEntityRef's setScope(), and PojoEntityManager's moveToPool() methods, to properly check that EntityRefs are removed from pools when they should be. Also fix the helper methods for moveToPool to ensure that EntityRefs are properly removed, and properly re-assigned to the correct pool.
Make remove() call unassignPool() on the EntityManager, so that the pool mapping is no longer registered. This Doesn't have an effect when using the method in moveToPool, but is more correct if the method is used in a different situation.
skaldarnar
approved these changes
Jul 19, 2017
|
Merged in MovingBlocks#3009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains fixes for @skaldarnar's feedback on #3, and some updates to
moveToPool().I haven't done anything with the
remove()method apart from updating the documentation for now, warning against improper use (I've also added an equivalent message to the partneringinsertRef()method).I updated some of the tests, and found and fixed a bug where moveToPool wasn't properly assigning the ref to the right pool using
assignToPool(), which led to it appearing to be in the original pool, when it was actually in the new pool.