-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ai sidebar indicators #142
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mluena, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces an AI Summaries feature to the report sidebar, allowing users to generate descriptive summaries for active topics based on a selected target audience. It also involves refactoring the sidebar structure and updating UI components.
Highlights
- AI Summaries Feature: Implements a new AI Summaries tab in the report sidebar, enabling users to generate summaries tailored to different audiences (General Public, Finance professionals, Conservationist).
- Sidebar Refactor: Replaces the
TopicsSidebar
with a more genericReportSidebar
that uses tabs to switch between 'Indicators' and 'AI Summaries'. - UI Updates: Updates the radio group component to use
LuCircle
instead ofLuCheck
for a different visual style. - State Management: Introduces
aiSummaryParser
anduseSyncAiSummary
to manage the selected AI summary options in the application state.
Changelog
Click here to see the changelog
- client/src/app/parsers.ts
- Added
aiSummaryParser
to parse and provide default values for AI summary options (type and only_active).
- Added
- client/src/app/report/results/page.tsx
- Replaced
TopicsSidebar
withReportSidebar
to accommodate the new AI Summaries feature.
- Replaced
- client/src/app/store.ts
- Imported
aiSummaryParser
and createduseSyncAiSummary
hook to manage AI summary state usinguseQueryState
.
- Imported
- client/src/components/ui/radio-group.tsx
- Replaced
LuCheck
icon withLuCircle
in theRadioGroupItem
component for a different visual representation.
- Replaced
- client/src/containers/report/indicators/sidebar/index.tsx
- Removed the
TopicsSidebar
component as its functionality is now integrated into theReportSidebar
.
- Removed the
- client/src/containers/report/sidebar/ai-content/card/index.tsx
- Created
AiSidebarContentCard
component to display individual audience options with a radio button and description. - Uses
useSyncAiSummary
to highlight the selected audience option.
- Created
- client/src/containers/report/sidebar/ai-content/index.tsx
- Created
AiSidebarContent
component to display the AI Summaries options, including audience selection and a disclaimer about potential inaccuracies.
- Created
- client/src/containers/report/sidebar/index.tsx
- Created
ReportSidebar
component, which uses tabs to switch between the Indicators and AI Summaries sections. - Integrates existing indicator-related components (search, topics list, clear indicators) and the new
AiSidebarContent
component.
- Created
- client/src/containers/results/content/item.tsx
- Imported
useSyncAiSummary
to access the AI summary state. - Conditionally renders the
ReportResultsSummary
component based on the existence ofai_summary
.
- Imported
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The Tab key on a keyboard got its name from the word 'tabulate', which means to arrange data in a table.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces AI summary functionality to the report sidebar, allowing users to generate descriptive summaries for active topics based on selected audience profiles. The changes include adding a new parser for AI summary parameters, creating new components for the AI summary sidebar content, and integrating these components into the report results page. Overall, the code appears well-structured and addresses the intended functionality.
Merge Readiness
The pull request introduces new functionality and appears to be well-structured. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. Given the absence of any CRITICAL or HIGH severity issues, the pull request seems to be in good shape to be merged.
f4a8f65
to
ec54969
Compare
2eec39d
to
6c8d5a7
Compare
No description provided.