Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to analysis table individual indicators #1079

Merged

Conversation

barbara-chaves
Copy link
Contributor

@barbara-chaves barbara-chaves commented Oct 10, 2023

General description

This PR fixes 2 bugs:

  1. Add units to analysis table individual indicators LANDGRIF-1486
  2. Fixed error message date for faled data upload LANDGRIF-1493

testing instructions

Bug 1

  1. Go to '/data'. If there is no upload error message, upload a file with errors.
  2. The upload error message date should be correct
Screenshot 2023-10-10 at 16 09 31

Bug 2

  1. Go to '/analysis/table'. Click on a indicator. You will see the indicator’s data.
  2. The indicator's unit should be displayed after the row value for all columns, except the comparison column.
  3. Be sure that the unit is correct. Check if is the same displayed at the info text above the table
Screenshot 2023-10-10 at 16 16 35

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 1:22pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Oct 11, 2023 1:22pm
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 1:22pm

@davidsingal davidsingal force-pushed the client/bugfix/LANDGRIF-1493-date-in-error-message-data-upload branch from aaea386 to 385f39e Compare October 11, 2023 13:18
@davidsingal davidsingal merged commit e674415 into dev Oct 11, 2023
@davidsingal davidsingal deleted the client/bugfix/LANDGRIF-1493-date-in-error-message-data-upload branch October 11, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants