Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LANDGRIF-1532] scenario creation: display errors below inputs #1175

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

andresgnlez
Copy link
Member

General description

Displays errors below inputs.

Also, moved form validation from yup to zod.

image
image

https://vizzuality.atlassian.net/browse/LANDGRIF-1532

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@andresgnlez andresgnlez self-assigned this Apr 25, 2024
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 7:15am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 7:15am
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 7:15am

@andresgnlez andresgnlez force-pushed the LANDGRIF-1532-fe-provide-explicit-error branch from 97438f4 to d44b8aa Compare April 29, 2024 07:12
@andresgnlez andresgnlez merged commit fe790ec into dev Jun 10, 2024
5 checks passed
@andresgnlez andresgnlez deleted the LANDGRIF-1532-fe-provide-explicit-error branch June 10, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant