Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A]: ensures session on first render #1176

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

andresgnlez
Copy link
Member

General description

This PR ensures the session is passed to the <SessionProvider /> and populates the profile query with the data coming from the session, avoiding displaying loaders the first time the user info is displayed.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@andresgnlez andresgnlez self-assigned this Apr 29, 2024
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 2:27pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Apr 29, 2024 2:27pm
landgriffon-marketing ⬜️ Ignored (Inspect) Apr 29, 2024 2:27pm

@andresgnlez andresgnlez merged commit 526c644 into dev Apr 29, 2024
5 checks passed
@andresgnlez andresgnlez deleted the chore/client/session-on-render branch April 29, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant