Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] shared typing #1179

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

[N/A] shared typing #1179

wants to merge 1 commit into from

Conversation

andresgnlez
Copy link
Member

@andresgnlez andresgnlez commented May 6, 2024

General description

This PR implements Orval as part of the efforts to relay on the typing provided by the API instead of custom ones.

TODO:

  • ensure hooks only trigger with FE changes / changes in the swagger.spec

To detect changes, we can implement something like in https://github.com/Orcasa-Platform/orcasa/blob/main/client/.husky/post-merge#L5-L10

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 7:42am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 7:42am
landgriffon-marketing ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 7:42am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant