Feat/implement new indicator computing #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
alexeh
force-pushed
the
feat/implement-new-indicator-computing
branch
from
94a6dc0 to
344b2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new indicator name codes,
WWandWC, and integrates them across various modules in the codebase. The changes ensure that these new indicators are properly handled in the DTOs, services, and tests.Key changes include:
Addition of new indicator codes:
WWandWCto theINDICATOR_NAME_CODESenum inapi/src/modules/indicators/indicator.entity.ts.DTO updates:
WWandWCproperties to theIndicatorCoefficientsDtoclass inapi/src/modules/indicator-coefficients/dto/indicator-coefficients.dto.ts.Service updates:
QueryPropertyNamesTypeandQueryPropertyTypesto includeWWandWCinapi/src/modules/indicator-records/services/impact-calculation.dependencies.ts. [1] [2]QueryPropertyNamesandINDICATOR_NAME_CODE_TO_QUERY_MAPto includeWWandWCinapi/src/modules/indicator-records/services/impact-calculation.dependencies.ts. [1] [2]WWandWCin theImpactCalculatorclass inapi/src/modules/indicator-records/services/impact-calculator.service.ts.Test updates:
WWandWCinapi/test/integration/indicator-record/calculations/indicator-records.service.spec.ts.