(chore) suggestions for deprecated GH actions stuff, Feb 2023 edition #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
alexeh
force-pushed
the
dev
branch
5 times, most recently
from
e072d47 to
0740fd3
Compare
alexeh
force-pushed
the
dev
branch
4 times, most recently
from
debfccb to
6d94cb7
Compare
Adds support for sorting the Impact Tables by the value corresponding to the given sortingYear, and in the giving sortingOrder. Also corrects a small bug in the absoluteDifference calculations in ScenarioVsScenario comparison tables
v2 runs on Node v12 and as such is deprecated by GitHub, as they intend to eventually discontinue Node v12 on GH-hosted runners at some point by Summer 2023. See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Ahead of planned discontinuing of set-outout via stdout: see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
alexeh
force-pushed
the
chore/infra/suggestions-for-deprecated-gh-action-stuff-feb-2023-edition
branch
from
d0bdcf5 to
d7c470a
Compare
alexeh
force-pushed
the
dev
branch
2 times, most recently
from
2fff34a to
8a3eb61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General description
Since I copypasted some of this for Foodscapes' GH actions recently and updated the bits that GH marked as deprecated, I thought I'd contribute my
changesbugs back.I've left
aws-actions/configure-aws-credentials@v1alone even though they now support Node v16 via@v1-node16, because I think that at this stage and with a few months to go before GH fully removes the ability to use Node v12 for actions, it may be best to wait for a new major release from theaws-actionsteam, rather than only using the@v1-node16flavour "just" to squash deprecation warnings.Designs
N/A
Testing instructions
All changed actions should run correctly as before.
Although I've tried to be careful and "just" backport the changes I did for the Foodscapes actions after copypasting the relevant LG actions, please cross check. If you come after me with a roaring chainsaw, I'll cast a disappearance spell.
Checklist before merging