[MRXN23-488]: map legend: merges binary and continuous features #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andresgnlez
changed the base branch from
MRXN23-458-fe-implementation-of
to
develop
andresgnlez
force-pushed
the
MRXN23-488-fe-binary-raw-vs
branch
from
3c33209 to
ebf51e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups binary and continuous features in map legend.
Overview
This PR groups binary and continuous features in the map legend. The criteria to difference between binary and continuous is checking the properties
minandmaxin every feature. These properties are not implemented in the API yet so it's not possible to distinguish between both types of properties right now.Designs
–
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
https://vizzuality.atlassian.net/browse/MRXN23-488
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)