Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRXNM-41] Ignores CSV file as part of the API Event data column #1682

Merged

Conversation

KevSanchez
Copy link
Collaborator

When uploading large CSV files, it would crash when trying to insert the CSv import submitted api_event, because the whole is included in the data property. It will now be ignored and not included, as it might be useful but not much, and the files could be as if larger.

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets

https://vizzuality.atlassian.net/browse/MRXNM-41

Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview Apr 18, 2024 6:36pm

@KevSanchez KevSanchez requested a review from hotzevzl April 19, 2024 08:04
@hotzevzl hotzevzl merged commit 2cf344d into develop Apr 19, 2024
61 checks passed
@hotzevzl hotzevzl deleted the fix/api/MRXNM-41-ignore-blob-on-csv-submitted-api-event branch April 19, 2024 08:41
@KevSanchez KevSanchez changed the title [MRXN-41] Ignores CSV file as part of the API Event data column [MRXNM-41] Ignores CSV file as part of the API Event data column Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants