Skip to content

Commit

Permalink
Switch committer builds to public runners (apache#39106)
Browse files Browse the repository at this point in the history
Following the discussion on devlist, we are switching committer buids to
public runners.

Discussion:

* https://lists.apache.org/thread/f2kxdjm12nf2rh0tqxmv3rj49sjd6c3w
  • Loading branch information
potiuk authored Apr 18, 2024
1 parent cd88887 commit ab9444e
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 14 deletions.
5 changes: 1 addition & 4 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -1090,10 +1090,7 @@ def runs_on_as_json_default(self) -> str:
if USE_SELF_HOSTED_RUNNERS_LABEL in self._pr_labels:
# Forced self-hosted runners
return RUNS_ON_SELF_HOSTED_RUNNER
if actor in COMMITTERS:
return RUNS_ON_SELF_HOSTED_RUNNER
else:
return RUNS_ON_PUBLIC_RUNNER
return RUNS_ON_PUBLIC_RUNNER
return RUNS_ON_PUBLIC_RUNNER

@cached_property
Expand Down
20 changes: 10 additions & 10 deletions dev/breeze/tests/test_selective_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -1700,13 +1700,13 @@ def test_helm_tests_trigger_ci_build(files: tuple[str, ...], expected_outputs: d
"apache/airflow",
(),
dict(),
'["self-hosted", "Linux", "X64"]',
"true",
"true",
"true",
'["ubuntu-22.04"]',
"false",
"false",
"true",
"false",
"false",
"false",
False,
id="Pull request committer",
),
Expand Down Expand Up @@ -1780,13 +1780,13 @@ def test_helm_tests_trigger_ci_build(files: tuple[str, ...], expected_outputs: d
"apache/airflow",
[],
dict(),
'["self-hosted", "Linux", "X64"]',
"true",
"true",
"true",
'["ubuntu-22.04"]',
"false",
"false",
"true",
"false",
"false",
"false",
False,
id="Pull request target committer",
),
Expand Down Expand Up @@ -2065,7 +2065,7 @@ def test_mypy_matches(
("README.md",),
{
"is-committer-build": "true",
"runs-on-as-json-default": '["self-hosted", "Linux", "X64"]',
"runs-on-as-json-default": '["ubuntu-22.04"]',
},
"potiuk",
(),
Expand All @@ -2075,7 +2075,7 @@ def test_mypy_matches(
("README.md",),
{
"is-committer-build": "false",
"runs-on-as-json-default": '["self-hosted", "Linux", "X64"]',
"runs-on-as-json-default": '["ubuntu-22.04"]',
},
"potiuk",
("non committer build",),
Expand Down

0 comments on commit ab9444e

Please sign in to comment.