Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new run type "triggered" to distinguish manual DAG runs and triggered runs #10

Closed
wants to merge 1 commit into from

Conversation

molcay
Copy link
Collaborator

@molcay molcay commented Jan 29, 2024

Add new run type "triggered" to distinguish manual DAG runs and triggered DAG runs (TriggerDagRunOperator).

Justification to introduce a new RunType

Before this improvement, we were prepending the run id with the string "manual" for TriggerDagRunOperator as well as manual run (which can be started on UI). This can cause a misunderstanding when we look for the logs and also for the UI. We did not have a way to distinguish manual runs and the triggered runs (which can be done with TriggerDagRunOperator).

To accomplish this, I introduced the followings:

  • A new RunType value:
TRIGGERED = "triggered"
  • A new icon for UI:

    import { MdBolt } from "react-icons/md";
    // ...
        case "triggered":
          return <MdBolt style={iconStyle} {...rest} />;
    //...

    which is look likes the following (in action):
    output

    Of course, we can change the icon with another icon that can be more suitable but as a entry point, I selected this one.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@molcay molcay changed the title [WIP] Add new run type "triggered" to separate manual DAG runs and triggered runs [WIP] Add new run type "triggered" to distinguish manual DAG runs and triggered runs Jan 30, 2024
@molcay molcay changed the title [WIP] Add new run type "triggered" to distinguish manual DAG runs and triggered runs Add new run type "triggered" to distinguish manual DAG runs and triggered runs Jan 30, 2024
@molcay molcay marked this pull request as ready for review January 30, 2024 08:22
@molcay molcay closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants