DAG import timeouts recorded in Airflow Database and displayed in Airflow UI #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladaZakharova
requested review from
molcay,
MaksYermak,
moiseenkov and
olegkachur-e
VladaZakharova
force-pushed
the
parse-import-error
branch
from
53e3907 to
460a449
Compare
moiseenkov
requested changes
Sep 6, 2024
VladaZakharova
force-pushed
the
parse-import-error
branch
from
460a449 to
abc883a
Compare
moiseenkov
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With old logic every ImportError that was raised by Timeout of reading the DAG was not stored in database and as a result, was not exposed to UI.
This PR adds additional Exception type to be catch, that will ensure that AirflowTaskTimeout exception will be also caught and stored in DB as other normal Import errors.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.