Add support for IAM database authentication for CloudSQL connection #122
+518
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksYermak
requested review from
molcay,
moiseenkov,
VladaZakharova and
olegkachur-e
providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query_iam.py
Outdated
Show resolved
Hide resolved
providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query_iam.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/google/cloud/hooks/cloud_sql.py
Outdated
Show resolved
Hide resolved
providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query_iam.py
Outdated
Show resolved
Hide resolved
providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query_iam.py
Show resolved
Hide resolved
providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query_iam.py
Outdated
Show resolved
Hide resolved
MaksYermak
force-pushed
the
add-cloudsql-iam-support
branch
2 times, most recently
from
5b7796e to
02b1196
Compare
|
@moiseenkov @VladaZakharova I have added a Documentation for this functionality. Could you please review this doc and let me know? |
MaksYermak
force-pushed
the
add-cloudsql-iam-support
branch
from
02b1196 to
255250a
Compare
|
@michalmodras thank you for the review! I have fixed the typos |
kosteev
approved these changes
Oct 23, 2024
providers/src/airflow/providers/google/cloud/hooks/cloud_sql.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/google/cloud/hooks/cloud_sql.py
Outdated
Show resolved
Hide resolved
MaksYermak
force-pushed
the
add-cloudsql-iam-support
branch
from
7944d78 to
65c2641
Compare
MaksYermak
force-pushed
the
add-cloudsql-iam-support
branch
from
65c2641 to
693435c
Compare
|
Hello @kosteev could you please check this PR one more time? |
kosteev
approved these changes
Oct 31, 2024
providers/src/airflow/providers/google/cloud/hooks/cloud_sql.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added support for IAM authentication to the Postgres and MySQL databases for Cloud SQL connection.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.