Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring of example_cloud_sql_iam and example_composer system tests #133

Closed
wants to merge 1 commit into from
Closed

Small refactoring of example_cloud_sql_iam and example_composer system tests #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion providers/tests/system/google/cloud/cloud_sql/example_cloud_sql_query_iam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@
"dataDiskSizeGb": 30,
"pricingPlan": "PER_USE",
"ipConfiguration": {},
"databaseFlags": [
{
"name": "cloudsql_iam_authentication",
"value": "on"
}
],
},
# For using a different database version please check the link below.
# https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1/SqlDatabaseVersion
Expand Down Expand Up @@ -118,7 +124,7 @@ def cloud_sql_instance_create_body(database_provider: dict[str, Any]) -> dict[st

CLOUD_SQL_DATABASE_NAME = "test_db"
CLOUD_SQL_USER = "test_user"
CLOUD_IAM_SA = os.environ.get("CLOUD_IAM_SA", "test_iam_sa")
CLOUD_IAM_SA = os.environ.get("SYSTEM_TESTS_CLOUDSQL_SA", "test_iam_sa")
CLOUD_SQL_IP_ADDRESS = "127.0.0.1"
CLOUD_SQL_PUBLIC_PORT = 5432

Expand Down
2 changes: 1 addition & 1 deletion providers/tests/system/google/cloud/composer/example_cloud_composer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

ENVIRONMENT = {
"config": {
"software_config": {"image_version": "composer-2.5.0-airflow-2.5.3"},
"software_config": {"image_version": "composer-2-airflow-2"},
}
}
# [END howto_operator_composer_simple_environment]
Expand Down
Loading