Refactor GKE hooks #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiseenkov
requested review from
molcay,
MaksYermak,
e-galan and
VladaZakharova
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
8628440 to
562b856
Compare
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
4616eb0 to
96b8dc8
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
562b856 to
e90d872
Compare
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
96b8dc8 to
c860821
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
e90d872 to
dce6fd9
Compare
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
c860821 to
972ef1e
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
dce6fd9 to
7b865b8
Compare
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
972ef1e to
641fece
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
7b865b8 to
1e4aba4
Compare
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
641fece to
809a789
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
1e4aba4 to
b966ed8
Compare
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
809a789 to
aa7f1a0
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
b966ed8 to
f986a02
Compare
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
aa7f1a0 to
456fb4e
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
f986a02 to
62e4ed9
Compare
VladaZakharova
approved these changes
Mar 21, 2024
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
456fb4e to
801a8a0
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
62e4ed9 to
6bd9909
Compare
MaksYermak
approved these changes
Mar 21, 2024
moiseenkov
force-pushed
the
k8s-start-job-deferrable
branch
from
801a8a0 to
64d7e2d
Compare
moiseenkov
force-pushed
the
gke-hooks-refactor
branch
from
6bd9909 to
1d7def0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce code duplication and high complexity of the implementation, GKE hooks were refactored in this PR:
GKEHookandGKEAsyncHookprovide interface to GKE API remain unchanged.GKEKubernetesHook(GoogleBaseHook, KubernetesHook)was introduced as a replacement for redundant hooks that used to contain duplicated methods that now are simply inherited fromGoogleBaseHookandKubernetesHook:GKEKubernetesAsyncHook(GoogleBaseAsyncHook, AsyncKubernetesHook)was introduced as a replacement for redundant hooks that used to contain duplicated methods that now are simply inherited fromGoogleBaseAsyncHookandAsyncKubernetesHook: