Implement on_status parameter for KubernetesDeleteJobOperator #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiseenkov
requested review from
molcay,
MaksYermak,
e-galan and
VladaZakharova
moiseenkov
force-pushed
the
gke-delete-job-on-status
branch
from
96afc82 to
38e7e18
Compare
|
Can you please update PR so it will be only your commits? :) |
|
Yes, seems that rebase wasn't clean. |
|
It's better now. Thanks for noticing |
VladaZakharova
approved these changes
Mar 25, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced three new parameters for
KubernetesDeleteJobOperator:on_status= None | "Complete" | "Failed" - remove the job regardless of its status | remove only successful jobs | remove only failed jobs. The default isNone.wait_until_job_complete- Whether to wait for the job to complete. The default value isFalse.job_poll_interval- Interval in seconds between polling the job status. Used when theon_statusparameter is set. The default value is 10.0.Default values for new parameters ensure that existing DAGs will work with no changes.