Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferrable mode for Dataflow sensors #33

Conversation

e-galan
Copy link

@e-galan e-galan commented Mar 25, 2024

Add the deferrable mode support for the Dataflow sensors:

  • DataflowJobAutoScalingEventsSensor
  • DataflowJobMessagesSensor
  • DataflowJobMetricsSensor
  • DataflowJobStatusSensor

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@e-galan e-galan self-assigned this Mar 25, 2024
@e-galan e-galan marked this pull request as draft March 25, 2024 08:58
@e-galan e-galan force-pushed the add-deferrable-mode-to-dataflow-job-auto-scaling-events-sensor branch from b3597f7 to ffe164a Compare March 25, 2024 08:59
@e-galan e-galan marked this pull request as ready for review March 25, 2024 09:36
Copy link
Collaborator

@moiseenkov moiseenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This PR is good to go once the previous comment is addressed.

@e-galan e-galan force-pushed the add-deferrable-mode-to-dataflow-job-auto-scaling-events-sensor branch from ffe164a to a6f89fc Compare March 25, 2024 13:09
@e-galan e-galan closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants