Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encryption_configuration parameter to BigQuery operators #47

Closed
wants to merge 1 commit into from

Conversation

molcay
Copy link
Collaborator

@molcay molcay commented Apr 26, 2024

This PR contains adding encryption_configuration parameter to BigQueryCheckOperator and BigQueryTableCheckOperator to add CMEK key support for these operator.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@molcay molcay force-pushed the feat/add-cmek-key-param-to-bigquery branch from 18e1c00 to 019e4a3 Compare April 26, 2024 13:46
@e-galan
Copy link

e-galan commented Apr 26, 2024

@molcay Will you add unit tests?

@molcay molcay force-pushed the feat/add-cmek-key-param-to-bigquery branch from 019e4a3 to 974041e Compare April 29, 2024 11:41
@molcay
Copy link
Collaborator Author

molcay commented Apr 29, 2024

@molcay Will you add unit tests?

@e-galan, I think it is hard to add unit tests for this one because currently this encryption key is used for deferable mode. I am not sure how I can test and what I can test

@molcay molcay force-pushed the feat/add-cmek-key-param-to-bigquery branch from 974041e to 0eee331 Compare April 30, 2024 16:11
Copy link

@e-galan e-galan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@molcay molcay closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants