Disconnect GKE operators from deprecated hooks #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiseenkov
requested review from
molcay,
MaksYermak,
e-galan and
VladaZakharova
moiseenkov
force-pushed
the
gke/refator-hooks
branch
from
bedb6c5 to
8371379
Compare
e-galan
reviewed
Apr 26, 2024
e-galan
reviewed
Apr 26, 2024
|
LGTM and I also agree with Eugene about changing the log's message. |
moiseenkov
force-pushed
the
gke/refator-hooks
branch
from
8371379 to
76bce7a
Compare
moiseenkov
force-pushed
the
gke/refator-hooks
branch
from
8e7e7cc to
427d7e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors GKE operators through replacing deprecated hooks with refactored GKE hooks.