Fix deferrable mode for BeamRunJavaPipelineOperator #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksYermak
requested review from
molcay,
moiseenkov,
e-galan and
VladaZakharova
e-galan
reviewed
Apr 29, 2024
| @@ -606,22 +606,6 @@ def execute_sync(self, context: Context): | |||
| ) | |||
|
|
|||
| async def execute_async(self, context: Context): | |||
There was a problem hiding this comment.
Given that you've removed asyncio loop from the execute_async method, does it still need to be an async method?
There was a problem hiding this comment.
A good note I think not. I will check the code and refactor it if it is needed.
There was a problem hiding this comment.
@e-galan I have updated the code. Could you please check one more time?
VladaZakharova
approved these changes
Apr 30, 2024
MaksYermak
force-pushed
the
fix-defer-mode-beam-java-operator
branch
from
91dbd70 to
9e144be
Compare
VladaZakharova
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.