Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute AutoML operator links to Google Translation links #50

Closed
wants to merge 1 commit into from

Conversation

e-galan
Copy link

@e-galan e-galan commented Apr 30, 2024

Update deprecated AutoML operators with new links. Due to its future deprecation AutoML's URLs have been divided between Google Translation and Vertex AI services. This PR updates the operators that are going to be used only with Google Translation services.

I opted to create a new module airflow/providers/google/cloud/links/translate.py and put the new links there instead of updating the existing AutoML links in airflow/providers/google/cloud/links/automl.py because:

  • The links are leading to Google Translation urls anyway;
  • Corresponding AutoML urls are no longer accessible and will be deprecated in the future;
  • We were missing a module for the Google Translation links.

This PR is dependent on and should not be merged before apache#38673 .


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@e-galan e-galan force-pushed the fix-automl-links branch 3 times, most recently from 80dbb75 to 34c523f Compare May 15, 2024 20:41
@MaksYermak
Copy link
Collaborator

LGTM
@e-galan @VladaZakharova @moiseenkov @molcay do we plan to remove unused links for AutoML service in a future? Or maybe we can remove unused links now?

@e-galan
Copy link
Author

e-galan commented May 16, 2024

LGTM @e-galan @VladaZakharova @moiseenkov @molcay do we plan to remove unused links for AutoML service in a future? Or maybe we can remove unused links now?

I don't know about the deprecation policy regarding the links. Can we just remove them, or should I add deprecation warnings?

@moiseenkov
Copy link
Collaborator

I'd follow our deprecation policy with all types of objects (not only hooks and operators), because customers' source code could import and use anything. That's why IMHO we should deprecate links if they are not needed, and delete them only after EOL.

@e-galan e-galan force-pushed the fix-automl-links branch from 34c523f to de52931 Compare May 16, 2024 12:06
@e-galan
Copy link
Author

e-galan commented May 16, 2024

@MaksYermak @moiseenkov I added the deprecation warnings, please check.

@e-galan e-galan closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants