Implement new Google Search 360 operators #79
Conversation
molcay
force-pushed
the
feat/new-google-search-ads-reporting-api-operators
branch
from
28cd5d3 to
7d3adba
Compare
molcay
changed the title
molcay
changed the title
airflow/providers/google/marketing_platform/hooks/search_ads.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/marketing_platform/hooks/search_ads.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nice work. But could you please add a more explicit explanation that new operators replace the old, and we are deleting them because the old API reached the end of life and doesn't work anymore. I believe it would speed up a code review in the community and avoid unnecessary questions about breaking changes. We are not breaking anything. We are replacing broken operators with new working operators.
airflow/providers/google/marketing_platform/hooks/search_ads.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/marketing_platform/hooks/search_ads.py
Outdated
Show resolved
Hide resolved
molcay
force-pushed
the
feat/new-google-search-ads-reporting-api-operators
branch
from
7d3adba to
83d7595
Compare
|
Hi @moiseenkov, |
molcay
force-pushed
the
feat/new-google-search-ads-reporting-api-operators
branch
from
83d7595 to
45021c6
Compare
Thanks for a very detailed description. I'd only correct the last sentence: This PR does NOT break any working DAG, because it replaces not working functionality with the new one. |
|
@molcay could you please recreate this PR or rebase it, based on |
molcay
force-pushed
the
feat/new-google-search-ads-reporting-api-operators
branch
3 times, most recently
from
8e84b3a to
b010198
Compare
molcay
force-pushed
the
feat/new-google-search-ads-reporting-api-operators
branch
2 times, most recently
from
f30d7bf to
f146944
Compare
Remove the decommissioned operators # Conflicts: # tests/providers/google/marketing_platform/operators/test_search_ads.py
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
Remove the decommissioned operators
molcay
force-pushed
the
feat/new-google-search-ads-reporting-api-operators
branch
from
f146944 to
e3cd2e4
Compare
Implement new Google Search 360 operators
Remove the decommissioned operators
Here is a bit of an explanation for clearer understanding;
The previous Search Ads 360 Reporting API (which is currently in use in
google-provider) was already decommissioned on June 30, 2024 (see deatils). All new reporting development should use the new Search Ads 360 Reporting API.Currently, the Reporting operators, sensors and hooks are failing due to the decommission. The new API is not a replacement for the old one, it has a different approach and APIs. Therefore, we needed to implement new operators and remove the old ones. This PR does NOT break any working DAG, because it replaces not working functionality with the new one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.