Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example_bigtable system test #95

Closed
wants to merge 1 commit into from
Closed

Conversation

olegkachur-e
Copy link
Collaborator

Fix issues with bigtable system test:

  • ensure correct id strings with proper length, as it might be issues depending on length of SYSTEM_TESTS_ENV_ID value.
  • assign proper id values to resources used
  • add constants for resources names limits

Copy link
Owner

@VladaZakharova VladaZakharova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, for the task calls please add comments like this

        #TEST SETUP
        [create_instance_task, create_instance_task2]
        >> create_tables()
        #TEST BODY
        >> wait_for_table_replication_task
        >> update_clusters_and_instance()
        #TEST TEARDOWN
        >> delete_table_task
        >> delete_table_task2
        >> [delete_instance_task, delete_instance_task2]
    )

@olegkachur-e olegkachur-e force-pushed the fix/sys_test_bigtable branch 2 times, most recently from b82f3f4 to 82038c3 Compare August 28, 2024 14:07
* ensure correct id strings
* assign proper id values
@olegkachur-e olegkachur-e force-pushed the fix/sys_test_bigtable branch from 82038c3 to 99e54b7 Compare August 28, 2024 14:09
@olegkachur-e olegkachur-e marked this pull request as ready for review September 12, 2024 13:52
Copy link
Collaborator

@moiseenkov moiseenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good as well as the requested change is provided, and the system test is green on staging.

@olegkachur-e
Copy link
Collaborator Author

Closing as ready for the community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants