-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example_bigtable system test #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, for the task calls please add comments like this
#TEST SETUP
[create_instance_task, create_instance_task2]
>> create_tables()
#TEST BODY
>> wait_for_table_replication_task
>> update_clusters_and_instance()
#TEST TEARDOWN
>> delete_table_task
>> delete_table_task2
>> [delete_instance_task, delete_instance_task2]
)
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
tests/system/providers/google/cloud/bigtable/example_bigtable.py
Outdated
Show resolved
Hide resolved
b82f3f4
to
82038c3
Compare
* ensure correct id strings * assign proper id values
82038c3
to
99e54b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good as well as the requested change is provided, and the system test is green on staging.
Closing as ready for the community |
Fix issues with bigtable system test: