Adds Multi-Row Column Titles #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the column title includes `\n`, that column title weill break into two lines. If two adjacent titles on any row in the title are the same, those lines will be merges to save space.
| @@ -1027,7 +1093,8 @@ func (l *TableView) OnBeforeDraw(fn func(int, int, int, int)) { | |||
| // * rowCount - the number of visible rows | |||
| func (l *TableView) VisibleArea() (firstCol, firstRow, colCount, rowCount int) { | |||
| firstRow = l.topRow | |||
| maxDy := l.height - 3 | |||
| maxDy := l.height - l.titleRows - 1 | |||
There was a problem hiding this comment.
As I remember, 3 because of 1 for scrollbar. Now, if I understand the MR right, maxDy default value is 2. Why?
| return "" | ||
| } | ||
|
|
||
| if len(l.titleParts[col]) > row { |
There was a problem hiding this comment.
Nit: why col is checked for negative value but row is not?
| @@ -2,6 +2,8 @@ package clui | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "strings" | |||
There was a problem hiding this comment.
A general comment: could you add or change existing demo to show how to use such columns?
E.g, you can modify demos/tableview.go and unite two columns in the middle(I think, good candidates are "Number" and "Misc" - they are fairly small, adjacent and in the middle)
There was a problem hiding this comment.
Sure I will. I've been a bit busy, so I'll follow up on the next weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the column title includes
\n, that column title weill break intotwo lines. If two adjacent titles on any row in the title are the same,
those lines will be merges to save space.