Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality for updating sections dynamically #542

Merged
merged 22 commits into from
Nov 15, 2024
Merged

Add functionality for updating sections dynamically #542

merged 22 commits into from
Nov 15, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #523

@vitPinchuk vitPinchuk self-assigned this Nov 6, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.29060% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.18%. Comparing base (f9cd9e8) to head (e35fb00).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/migration.ts 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   99.19%   99.18%   -0.02%     
==========================================
  Files         115      115              
  Lines        1986     2077      +91     
  Branches      495      511      +16     
==========================================
+ Hits         1970     2060      +90     
- Misses         14       15       +1     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk mentioned this pull request Nov 6, 2024
Merged
@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 6, 2024
@mikhail-vl mikhail-vl added this to the Forms 4.9.0 milestone Nov 6, 2024
@vitPinchuk vitPinchuk marked this pull request as draft November 6, 2024 13:44
@vitPinchuk vitPinchuk marked this pull request as ready for review November 7, 2024 15:47
asimonok
asimonok requested changes Nov 11, 2024
View reviewed changes
src/hooks/useFormLayout.ts Outdated Show resolved Hide resolved
src/hooks/useFormLayout.ts Outdated Show resolved Hide resolved
src/utils/code-parameters.ts Outdated Show resolved Hide resolved
@mikhail-vl mikhail-vl changed the title Add and remove sections dynamically Add functionality for updating sections dynamically Nov 12, 2024
@vitPinchuk vitPinchuk requested a review from asimonok November 12, 2024 13:20
asimonok
asimonok approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 19773c7 into main Nov 15, 2024
6 of 8 checks passed
@mikhail-vl mikhail-vl deleted the feat/dynamic-sections branch November 15, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Forms 4.9.0
Development

Successfully merging this pull request may close these issues.

Dynamic panel layout
3 participants
@vitPinchuk @asimonok @mikhail-vl