Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Version 2 #1058

Closed
wants to merge 27 commits into from
Closed

Conversation

GalvanicGlaze
Copy link
Contributor

@GalvanicGlaze GalvanicGlaze commented Nov 1, 2024

Which mods are added by this PR? Its the bowden tube guide and I've added a bearing option

How was it tested? On my on printers and on printables

Any background context you want to provide? Small tweaks made to original design

Screenshots (if appropriate) https://www.printables.com/model/978123-voron-bowden-ptfe-tube-guide-arm-and-canbus-cable/comments

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

  • I have read the rules available here and
    my mod adheres to these rules.
  • This mod was created by myself and I agree to publish it under the repository
    license

@chirpy2605 chirpy2605 self-requested a review November 2, 2024 15:46
@chirpy2605 chirpy2605 self-assigned this Nov 2, 2024
Copy link
Collaborator

@chirpy2605 chirpy2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the new meta data file (metadata.yml) that is required for each mod. Have a read here:
https://github.com/VoronDesign/VoronUsers/wiki/How-to-build-a-metadata.yml-file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please reduce the size of this picture. It's current over 5MB which takes up a bunch of space. We prefer them to be below 1MB where possible

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same again for this picture, if you can compress the image down to under 1MB, please

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR as it is should no longer appear. See: https://github.com/VoronDesign/VoronUsers/wiki/Mod-Submission-Rules

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please zip this file to reduce its size

@chirpy2605
Copy link
Collaborator

Closing this due to lack of response. If you still want to issue this PR, please resubmit with the requested changes.

@chirpy2605 chirpy2605 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants