Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gender should not be required, and reduced the amount of data passed around #2350

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

egonw
Copy link
Collaborator

@egonw egonw commented Oct 15, 2023

Fixes #2347

Description

Adds the suggestion OPTIONAL and DISTINCT

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

Testing

Compare http://127.0.0.1:8100/organization/Q24283660 before and after the patch.

More people should show up:

image

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw added the max-5-lines Tag for pull requests to indicate the changes are at most 5 lines changed label Oct 15, 2023
@egonw egonw requested a review from fnielsen October 15, 2023 10:25
@fnielsen fnielsen merged commit d33fa47 into master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
max-5-lines Tag for pull requests to indicate the changes are at most 5 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPTIONAL missing for gender in advidor graph in Organization aspect
2 participants