Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'Cite' for datasets #2351

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Implement 'Cite' for datasets #2351

merged 2 commits into from
Oct 24, 2023

Conversation

egonw
Copy link
Collaborator

@egonw egonw commented Oct 15, 2023

Implements #2325

Description

Adds the Cite button to the dataset aspect.

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw requested review from larsgw and bluerasberry October 15, 2023 11:24
@egonw egonw linked an issue Oct 20, 2023 that may be closed by this pull request
@fnielsen
Copy link
Collaborator

The curation link disappears <a id='curation-link' role="button" class="btn btn-outline-secondary d-none">Improve data</a I think it is the page_actions` that does that.

@larsgw
Copy link
Collaborator

larsgw commented Oct 20, 2023

Oops, I missed that. Yes, I think it needs a {{ super() }} before endblock, that's what the work template has.

@egonw egonw assigned egonw and unassigned fnielsen Oct 20, 2023
@egonw
Copy link
Collaborator Author

egonw commented Oct 20, 2023

I'm on it.

@egonw egonw assigned fnielsen and unassigned egonw Oct 20, 2023
@fnielsen fnielsen merged commit 96c2fd1 into master Oct 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request cite feature for dataset aspect
3 participants