-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended subgrid functionality #49
Conversation
IMHO assemblytypes.jl needs to be included before subgrids.jl. Generally, formally removing API (including keyword args) is a breaking change. |
Yes, I am on it. Unfurtunately also som subgrid tests don't run through ^^ |
Ok, now it should work... I messed up the old CoordinateSystem handling for codimension -1 grids |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 73.01% 74.24% +1.23%
==========================================
Files 27 32 +5
Lines 4239 4589 +350
==========================================
+ Hits 3095 3407 +312
- Misses 1144 1182 +38 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One bug where based
is still used.
You are right. I fixed it the two 'based' occurences. No API was removed, boundary = true should still work as before and is also covered by the (same) tests. |
…nate sorting to project = true
Just checked with VoronoiFVM, tests are ok. |
extended subgrid features: