Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended subgrid functionality #49

Merged
merged 5 commits into from
Jun 20, 2024
Merged

extended subgrid functionality #49

merged 5 commits into from
Jun 20, 2024

Conversation

chmerdon
Copy link
Member

extended subgrid features:

  • new argument 'support' which can be ON_CELLS (default subgrid behaviour as before), ON_BFACES (default subgrid behaviour with boundary = true which also still works) and ON_FACES (new behaviour that generates a subgrid with faces)
  • SubGrid type has now a parameter that knows the support relative to parent grid, removed BoundarySubGrid type
  • removed get_facegrid, get_bfacegrid, get_edgegrid in derived.jl (that offer no new functionality compared to subgrid)

@chmerdon chmerdon requested a review from j-fu June 18, 2024 14:37
@j-fu
Copy link
Member

j-fu commented Jun 18, 2024

IMHO assemblytypes.jl needs to be included before subgrids.jl.

Generally, formally removing API (including keyword args) is a breaking change.
Unless we are really sure that nobody else uses this (I think I use boundary=true) we should keep the old API, possibly with a deprecation warning.

@chmerdon
Copy link
Member Author

Yes, I am on it. Unfurtunately also som subgrid tests don't run through ^^

@chmerdon
Copy link
Member Author

Ok, now it should work... I messed up the old CoordinateSystem handling for codimension -1 grids

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (06a2f11) to head (2eabbea).
Report is 43 commits behind head on master.

Files Patch % Lines
src/subgrid.jl 52.94% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   73.01%   74.24%   +1.23%     
==========================================
  Files          27       32       +5     
  Lines        4239     4589     +350     
==========================================
+ Hits         3095     3407     +312     
- Misses       1144     1182      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/subgrid.jl Outdated Show resolved Hide resolved
src/subgrid.jl Outdated Show resolved Hide resolved
Copy link
Member

@j-fu j-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bug where based is still used.

@chmerdon
Copy link
Member Author

You are right. I fixed it the two 'based' occurences. No API was removed, boundary = true should still work as before and is also covered by the (same) tests.

@chmerdon chmerdon requested a review from j-fu June 19, 2024 09:03
@j-fu
Copy link
Member

j-fu commented Jun 20, 2024

Just checked with VoronoiFVM, tests are ok.

@chmerdon chmerdon merged commit f3ff8f0 into WIAS-PDELib:master Jun 20, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants