Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GLMakie region colorbar in 2D/3D Plots #29

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix GLMakie region colorbar in 2D/3D Plots #29

merged 1 commit into from
Nov 8, 2024

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Nov 7, 2024

This displays the color bars in a GLMakie plot a bit different.

  • the correct number of boundary regions is now considered
  • the ticks are shifted by 0.5 to appear in the center of the segments
  • it is now guaranteed that all integers are displayed.

Before:
before3d
before2d

After:
after3d
after2d

Code example

grid = simplexgrid( 0:1, 0:1, 0:1 )
gridplot!( GridVisualizer(Plotter=GLMakie) , grid)

@pjaap pjaap requested a review from j-fu November 7, 2024 13:53
@pjaap
Copy link
Member Author

pjaap commented Nov 7, 2024

Probably fixes #21

j-fu
j-fu approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@j-fu j-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@j-fu
Copy link
Member

j-fu commented Nov 7, 2024

You could try to merge and register. I consider this as a bugfix, so new version would be 1.8.2.

@pjaap pjaap merged commit 1d77234 into main Nov 8, 2024
7 of 8 checks passed
@pjaap pjaap deleted the fix/GLMakie_colorbar branch November 8, 2024 08:12
@pjaap
Copy link
Member Author

pjaap commented Nov 8, 2024

Yes, I'll bump the version and register.

@pjaap pjaap mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-fu j-fu j-fu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjaap @j-fu