fix: make indexing robust if config is invalid

WPP-Public · Jan 9, 2023 · 5a8403b · 5a8403b
1 parent dca145d
commit 5a8403b
Showing 1 changed file with 18 additions and 4 deletions.
diff --git a/src/ElasticaService.php b/src/ElasticaService.php
@@ -105,10 +105,14 @@ public function getClient()
     }
 
     /**
-     * @return Index
+     * @return ?Index
      */
     public function getIndex()
     {
+        if (!$this->indexName) {
+            return null;
+        }
+
         return $this->getClient()->getIndex($this->indexName);
     }
 
@@ -209,9 +213,14 @@ public function index($record)
         // Add document
         return $this->runQuery(
             function () use ($index, $document) {
-                $response = $index->addDocument($document);
-                $index->refresh();
-                return $response;
+                if ($index) {
+                    $response = $index->addDocument($document);
+                    $index->refresh();
+
+                    return $response;
+                }
+
+                return null;
             }
         );
     }
@@ -341,6 +350,11 @@ public function remove($record)
 
         try {
             $index = $this->getIndex();
+
+            if (!$index) {
+                return false;
+            }
+
             $typeName = $record->getElasticaType();
             $document = $record->getElasticaDocument();
             // If batching