This repository has been archived by the owner on Apr 3, 2021. It is now read-only.

goToOffset + Keyboard direction #5

Open

jgi-comspace wants to merge 2 commits into WSJ:master from jgi-comspace:master

jgi-comspace commented Feb 14, 2019

Hi!
This PR contains two small changes/fixes:

The offset for "scrollThere" in .goTo() was hard coded to -100, which isn't always useful. The option goToOffset was added and documented in the readme to address this. The default value is still -100 to ensure backwards compatibility.
When using the Keyboard navigation, no directions were handed over to "goTo()" – this could be easily fixed, since the direction is known at that point.

cheers,
John Gibbon

jgi-comspace added 2 commits

February 14, 2019 09:58


          configurable goTo offset

9fee976


          hand over direction string for keyboard navigation

7af86bb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet