Update node engine to use LTS versions 18 (and soon 20) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe an even better solutions would be to remove the engine config as strapi itselfs handles it. See this comment on an other strapi plugin: ckeditor/strapi-plugin-ckeditor#84 (comment) |
|
The main project has conflict with newer versions of strapi on node 20 . |
|
It would be great to get it merged 🙏 |
|
Please merge this, I'd like to update to node 20! |
|
@WalkingPizza could you take a look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Active LTS starting for v20 the 24th of October, it would be good to update the engine config in package.json. This way we won't run into an incompatibility error when install the package. Also since last September v16 is EOL.
https://nodejs.dev/en/about/releases
