Skip to content

Commit

Permalink
[inspector] finally removed *ExecuteScript from inspector
Browse files Browse the repository at this point in the history
We don't need hints from embedder any more.

BUG=none
[email protected]

Review-Url: https://codereview.chromium.org/2773143002
Cr-Commit-Position: refs/heads/master@{#44158}
  • Loading branch information
alexkozy authored and Commit bot committed Mar 27, 2017
1 parent 6235899 commit 43791ce
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
2 changes: 0 additions & 2 deletions include/v8-inspector.h
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector {
virtual void resetContextGroup(int contextGroupId) = 0;

// Various instrumentation.
virtual void willExecuteScript(v8::Local<v8::Context>, int scriptId) = 0;
virtual void didExecuteScript(v8::Local<v8::Context>) = 0;
virtual void idleStarted() = 0;
virtual void idleFinished() = 0;

Expand Down
7 changes: 0 additions & 7 deletions src/inspector/v8-inspector-impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -239,13 +239,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) {
m_debugger->wasmTranslation()->Clear();
}

void V8InspectorImpl::willExecuteScript(v8::Local<v8::Context> context,
int scriptId) {
}

void V8InspectorImpl::didExecuteScript(v8::Local<v8::Context> context) {
}

void V8InspectorImpl::idleStarted() {
for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) {
if (it->second->profilerAgent()->idleStarted()) return;
Expand Down
2 changes: 0 additions & 2 deletions src/inspector/v8-inspector-impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ class V8InspectorImpl : public V8Inspector {
void contextCreated(const V8ContextInfo&) override;
void contextDestroyed(v8::Local<v8::Context>) override;
void resetContextGroup(int contextGroupId) override;
void willExecuteScript(v8::Local<v8::Context>, int scriptId) override;
void didExecuteScript(v8::Local<v8::Context>) override;
void idleStarted() override;
void idleFinished() override;
unsigned exceptionThrown(v8::Local<v8::Context>, const StringView& message,
Expand Down

0 comments on commit 43791ce

Please sign in to comment.