Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skinning festival #1575

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

skinning festival #1575

wants to merge 17 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2020

Changelog:

Developer changelog:

How to test:

make sure everything has localisations

@ghost ghost self-requested a review as a code owner May 18, 2020 16:50
@ghost ghost marked this pull request as draft May 18, 2020 16:50
@5sanon
localisations
39aa0ba 
added loc and changed events
@5sanon
added more loc
cb7f140 
added loc and changed events
@zumbak04 zumbak04 added 🚧 WIP 🚧 This pull request or issue's solution is a work in progress ❕ priority low Issue or addition is low priority 📄 localisation 🖊️ Adding or adjusting localisations ⭐ new feature 🆕 Adding a new feature to the mod labels May 19, 2020
@zumbak04 zumbak04 added this to the Patch 1.9.0 milestone May 19, 2020
@zumbak04 zumbak04 assigned ghost May 19, 2020
@zumbak04
Copy link
Member

zumbak04 commented May 19, 2020 •
edited
Loading

So, I wouldn't copypaste vanilla code for a decision and there are 2 reasons:

  • Paradox code is messy. It's old and there's a lot of outdated things. It's massive but doesn't do much.
  • If there are no big changes (like the event chain is completely new), better just take the vanilla events (I'm not about copying), write new localization, and show different localization depending on character culture and religion (feel free to ask me how to do it).

So, I recommend you either designing your own event chain or relocalizating Paradox's one.

@ghost
Copy link
Author

ghost commented May 19, 2020

zumbak04

So, I wouldn't copypaste vanilla code for a decision and there are 2 reasons:

  • Paradox code is messy. It's old and there's a lot of outdated things. It's massive but doesn't do much.
  • If there are no big changes (like the event chain is completely new), better just take the vanilla events (I'm not about copying), write new localization, and show different localization depending on character culture and religion (feel free to ask me how to do it).

So, I recommend you either designing your own event chain or relocalizating Paradox's one.

i will make my own

@5sanon
finished loc, pictures, modifiers
947db4a 
i did not completely change the copy paste yet, but most of the stuff is done
probably will change pictures
@5sanon
Update 00_fives_united_localisation.csv
6a92b0d
@zumbak04
Copy link
Member

I would recommend doing it from scratch, otherwise, in my opinion, you would repeat Paradox errors.

@ghost
Copy link
Author

ghost commented Jun 6, 2020 •
edited by ghost
Loading

help, i have no idea why the event wont work. the indentation and brackets and shit seem fine but the two options are fuckin combined and shit idk
by combine i mean one option costs 25 the other is supposed to end the event chain and i havnt removed the add 25 wealth which i put in earlier before i changed some stuff but yeah.

image

@zumbak04
Merge remote-tracking branch 'remotes/origin/master' into pr/1575
adabac5 
# Conflicts:
#	common/event_modifiers/wc_cooldown_modifiers.txt
#	common/modifier_definitions/wc_opinion_modifier_definitions.txt
#	common/on_actions/00_on_actions.txt
#	common/scripted_effects/wc_scripted_effects.txt
#	common/scripted_triggers/wc_scripted_triggers.txt
#	common/scripted_triggers/wcsp_scripted_triggers.txt
#	interface/wc_decision_icons.gfx
#	interface/wc_event_pictures.gfx
#	localisation/00_zuwc_united_localisation.csv
@zumbak04
Sorted HF_realm_decisions.txt
ec9c072 
(GDC)
zumbak04
zumbak04 reviewed Jun 6, 2020
View reviewed changes
events/wc_gnoll_events.txt Outdated Show resolved Hide resolved
zumbak04
zumbak04 reviewed Jun 6, 2020
View reviewed changes
events/wc_gnoll_events.txt Outdated Show resolved Hide resolved
@zumbak04 zumbak04 modified the milestones: Patch 1.9.0, Soon™ Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚧 WIP 🚧 This pull request or issue's solution is a work in progress ❕ priority low Issue or addition is low priority 📄 localisation 🖊️ Adding or adjusting localisations ⭐ new feature 🆕 Adding a new feature to the mod
Projects
None yet
Milestone
Soon™
Development

Successfully merging this pull request may close these issues.
2 participants
@zumbak04 @5sanon