Greymane bloodline #1701
Open
Greymane bloodline #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create 00_greymane bc localisation just get corrupted then i just create a new a little .csv file with only new things. DO NOT COPY ZUCW FILE ITS ALL CORRUPTED, LET THIS FILE STAY OR COPY THINGS IN THIS FILE TO ZUCW FILE (bc i just cant its getting corrupted)
|
Fixed the changelog. |
zumbak04
reviewed
Jul 15, 2020
| @@ -0,0 +1 @@ | |||
| 15.7.2020 Added Greymane bloodline | |||
Comment on lines
+1
to
+2
| greymane;Blood of [This.GetFirstNameWithNick];Sang de [This.GetFirstNameWithNick];Blut von [This.GetFirstNameWithNick];;;;;;;;;;;x | ||
| greymane_desc;Archibald Greymane was the king of Gilneas and the father of Genn Greymane. Under his rule, Gilneas prospered. His views on asking for help were that it was for the weak.;;;;;;;;;;;;;x |
There was a problem hiding this comment.
What is a point of this file? These lines exist in localisation/00_zuwc_united_localisation.csv.
There was a problem hiding this comment.
i accidently uploaded the test file.
zumbak04
reviewed
Jul 16, 2020
did the things zumbak said
…oodline # Conflicts: # localisation/00_zuwc_united_localisation.csv
zumbak04
requested changes
Jul 26, 2020
| gilnean_opinion = 10 | ||
|
|
||
| local_revolt_risk = 0.05 |
There was a problem hiding this comment.
local_revolt_risk doesn't work with characters, no?
https://ck2.paradoxwikis.com/Modifiers
| local_revolt_risk = 0.05 | ||
|
|
||
| local_tax_modifier = 0.05 |
There was a problem hiding this comment.
local_tax_modifier doesn't work with characters, no?
https://ck2.paradoxwikis.com/Modifiers
| monthly_character_prestige = 0.15 | ||
|
|
||
| gilnean_opinion = 10 |
There was a problem hiding this comment.
The opinion is not declared in Warcraft-Guardians-of-Azeroth\common\modifier_definitions\wc_opinion_modifier_definitions.txt
See how other opinions are handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
How to test:
Right Click on Gilneas, you will see greymane have a bloodline.