Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big artifact pictures for A Bigger Interface mod compatibility #1752

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

MemeWizard
Copy link
Contributor

Changelog:

  • Added big artifact pictures for A Bigger Interface mod compatibility

How to test:

  • Check that I didn't break small pictures.
  • get_all_artifacts console command can help you check jewelry and non-elemental weapon icons.

@MemeWizard MemeWizard added 🎨 2D graphics 🖌️ Adding 2D graphic files or adjustments ❕ priority low Issue or addition is low priority labels Aug 4, 2020
@MemeWizard MemeWizard added this to the Patch 1.9.0 milestone Aug 4, 2020
@MemeWizard MemeWizard requested review from zumbak04, arithon and a team August 4, 2020 22:13
@MemeWizard MemeWizard requested a review from a team as a code owner August 4, 2020 22:13
@MemeWizard MemeWizard self-assigned this Aug 4, 2020
Copy link
Contributor

@arithon arithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked without any problems for me. The only one I saw with a little flaw was the T5 intrigue ring, the small left gem merges too much with the background glow, its frame is less visible than in the others. However, at least the weapons might need a little more sharpness...

Copy link
Member

@zumbak04 zumbak04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check that I didn't break small pictures.

They LGTM!

Copy link
Contributor

@Myrran Myrran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Small pictures are fine.

Big pictures have issues:

  • Halberd, spear, two-handed mace, two-handed axe, two-handed sword, rifle, crossbow, bow, one-handed mace, one-handed axe, one-handed sword and necklace (amulet) need sharpening. I'd suggest sharpening Felo’melorn and Eye of Sargeras too;
Sharpening - lots of screenshots!

ck2_11
ck2_12
ck2_13
ck2_14
ck2_15
ck2_17
ck2_18
ck2_19
ck2_20
ck2_21
ck2_22
ck2_23
ck2_29
ck2_30

  • Big pictures that need fixing:
Fix big pictures - lots of screenshots!

ck2_1
ck2_3
ck2_4
ck2_5
ck2_6
ck2_7
ck2_8
ck2_9
ck2_10
ck2_16
ck2_31
ck2_32

  • Skull of Guldan is a libram;
Skull of Guldan is a libram

Skull of Guldan is a libram

  • I’d suggest making common spear icon bigger so that it matches other spear icons in size.
Common spear

Common spear

@arithon
Copy link
Contributor

arithon commented Aug 8, 2020

Skull of Guldan is a libram;

No, it has no image at all yet. In that case, the previous Image is shown.

GDC
blurry version
@zumbak04 zumbak04 modified the milestones: Patch 1.9.0, Soon™, 1.10 Aug 29, 2020
@zumbak04 zumbak04 modified the milestones: Patch 1.10, Patch 1.11 Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 2D graphics 🖌️ Adding 2D graphic files or adjustments ❕ priority low Issue or addition is low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants