Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nazjatar wonders #1866

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Nazjatar wonders #1866

wants to merge 48 commits into from

Conversation

sejtalk
Copy link
Contributor

@sejtalk sejtalk commented Mar 25, 2021 •
edited
Loading

NOTE TO ME

REMEMEMBER TO CHANGE POTENTIAL BEFORE MERGING!!!!!!!!!!!

Changelog:

  • Added Eternal Palace wonder with unique wonder upgrades.
  • Added Coral Forest wonder with unique wonder upgrades.
  • Added decison to recruit Coral Ancient character for owner of Coral Grove wonder upgrade.

Developer changelog:

How to test:

Use console commands "cash" and "quickbuild" to build both wonders. Ignore the construction loc since wonders will be changed to unbuildable before i merge.

@sejtalk sejtalk requested a review from a team as a code owner March 25, 2021 15:38
@sejtalk
added coral forest wonder upgrades(GIH)
edb4c46
@sejtalk
added coral forest icons code and fixed typo(GDC)
4a6ddf5
@sejtalk
changed brightness of three coral forest upgrades(GIH)
aa69e2c
@sejtalk
added eternal palace strip code
2b66e10
@sejtalk
added eternal palace upgrades icons(GIH)
5d3231e
@sejtalk
added eternal palace upgrades code(GDC)
0f3cf89
@sejtalk
fixed eternal palace icons brightness(GDC)
de28502
@sejtalk
added eternal palace localization
2e61227
@sejtalk
added coral forest localization
6589693
@sejtalk
replaced cenote wonder upgrade with kaldorei ruins in code(GDC)
b20ee55
@sejtalk
replaced cenote with kaldorei ruins graphics(GIH)
46c931c
@sejtalk
replaced cenote in avaible upgrades
74f93cb
@sejtalk
fixed kaldorei ruins icon(GIH)
088692a
@sejtalk
moved wonder upgrades to correct file(GDC)
7091456
@sejtalk
added wonder upgrade loc
80c65e8
@sejtalk
added more wonder upgrade loc(GDC)
0c0a82d
@sejtalk
added even more wonder upgrade loc
4e39a68
@sejtalk
unmute me reeee
13852bb
@sejtalk
finished nazjatar wonder loc
208aca8
@sejtalk sejtalk self-assigned this Apr 12, 2021
@sejtalk sejtalk added the ⭐ new feature 🆕 Adding a new feature to the mod label Apr 12, 2021
@sejtalk sejtalk added this to the Patch 1.11 milestone Apr 12, 2021
@sejtalk sejtalk requested a review from a team April 12, 2021 17:41
LordSilvermane
LordSilvermane reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@LordSilvermane LordSilvermane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor localization changes.

localisation/00_wc_wonders.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
localisation/00_wc_wonders_upgrades.csv Outdated Show resolved Hide resolved
LordSilvermane
LordSilvermane approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@LordSilvermane LordSilvermane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

arithon
arithon approved these changes Apr 18, 2021
View reviewed changes
Copy link
Contributor

@arithon arithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loc LGTM

@sejtalk sejtalk changed the title Nazjatar wonders(WIP) Nazjatar wonders Sep 15, 2021
arithon
arithon approved these changes Sep 18, 2021
View reviewed changes
Copy link
Contributor

@arithon arithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loc LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erkor001 Erkor001 Erkor001 left review comments

@arithon arithon arithon approved these changes

@LordSilvermane LordSilvermane LordSilvermane approved these changes

Assignees

@sejtalk sejtalk

Labels
🎨 2D graphics 🖌️ Adding 2D graphic files or adjustments ⭐ new feature 🆕 Adding a new feature to the mod
Projects
None yet
Milestone
Patch 1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@sejtalk @LordSilvermane @arithon @Erkor001